Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message_id parameter #63

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Add message_id parameter #63

merged 3 commits into from
Nov 29, 2023

Conversation

brandonjoyce
Copy link
Contributor

I need to have more fine-grained control over the message id generated. Hoping this makes sense to add!

abhishek-ram
abhishek-ram reviewed Nov 24, 2023
View reviewed changes
pyas2lib/as2.py Outdated Show resolved Hide resolved
@abhishek-ram
Copy link
Owner

you need to run black

@brandonjoyce
Copy link
Contributor Author

you need to run black

Done! I also have a lot of seemingly unrelated tests failing when I run locally what I'm copying from CI - pytest --cov=pyas2lib --cov-config .coveragerc --black --pylama. Python isn't an everyday language for me so I might be missing something obvious.

@abhishek-ram
Copy link
Owner

you need to run black

Done! I also have a lot of seemingly unrelated tests failing when I run locally what I'm copying from CI - pytest --cov=pyas2lib --cov-config .coveragerc --black --pylama. Python isn't an everyday language for me so I might be missing something obvious.

This is still failing

pyas2lib/as2.py:392:101 [E] E501 line too long (107 > 100 characters) [pycodestyle]

@brandonjoyce
Copy link
Contributor Author

This is still failing

pyas2lib/as2.py:392:101 [E] E501 line too long (107 > 100 characters) [pycodestyle]

I've fixed this and confirmed that CI passes now.

@abhishek-ram abhishek-ram merged commit af63a9b into abhishek-ram:master Nov 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishek-ram abhishek-ram abhishek-ram left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonjoyce @abhishek-ram